Conversation
|
Hi @efcasado |
|
Hi @falood I first considered creating a separate repo for this but after reviewing the code I thought it would be quite elegant to include the functionality in this repo. What would be your main concern in doing this? the size of the dependency (e.g. priv folder)? the breaking changes to the API? How do you suggest to move forward? Should I just create a maru_swagger_ui_repo and push my changes there? |
|
The dependency size is an important reason. For another reason, I think we shouldn't put code NOT make by us in our repo, for the do you think this way make sence? I have create a new repo https://github.com/elixir-maru/maru-swagger-ui , really glad to have your changes there Thank you very much! |
2 participants
This pull-request is all about seamlessly adding support for Swagger UI.
With this changes, all maru projects using this plug will not only be able to get the Swagger specification of their APIs, but they will also be able to tinker with it using Swagger UI.
This pull-request includes some breaking changes. For instance, the
atoption in the swagger macro does not longer refer to the endpoint where the Swagger specification can be found. Instead, it now points to the endpoint where the Swagger UI can be loaded. The swagger specification can be fetched by appending/swagger.jsonto the path provided inat.You can find a toy application using these changes in https://github.com/efcasado/hola_maru